Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the JSON.OBJKEYS command #1872

Merged
merged 17 commits into from
Nov 7, 2023
Merged

Conversation

jihuayu
Copy link
Member

@jihuayu jihuayu commented Nov 3, 2023

close #1820

Redis doc json.objkeys

@git-hulk
Copy link
Member

git-hulk commented Nov 4, 2023

@jihuayu I think only Go tests is ok if most of them can be covered.

@jihuayu
Copy link
Member Author

jihuayu commented Nov 4, 2023

@git-hulk I'm not quite understanding the difference in using between cpp test and go test in kvrocks. When should I add a cpp test, and when go test is OK?

@git-hulk
Copy link
Member

git-hulk commented Nov 4, 2023

rstanding the difference in using between cpp test and go test in kvrocks. When should I add a cpp test, and when go test is

No, only Go is ok if the key path can be tested. And cpp test is used to cover the path which is hard to test through the redis protocol way.

@jihuayu jihuayu marked this pull request as ready for review November 6, 2023 11:18
src/commands/cmd_json.cc Outdated Show resolved Hide resolved
git-hulk
git-hulk previously approved these changes Nov 6, 2023
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@git-hulk git-hulk merged commit a79a386 into apache:unstable Nov 7, 2023
30 checks passed
@jihuayu jihuayu deleted the f/1820 branch November 8, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the JSON.OBJKEYS command
2 participants